sanity: Disable ListVolumes pagination test #226

avalluri · 2019-10-10T09:29:14Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
Volume created by testcase is not adding to cleanup list, hence it results in
volume leaking. This change fixes this issue.

The side effect of this testcase fix discovered a minor issue in mock driver implementation.
Which was hidden due to the leftover volume created by above testcase.

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2019-10-10T09:29:27Z

Hi @avalluri. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pohly · 2019-10-10T13:37:37Z

As discussed in intel/pmem-csi#424 (comment), the ListVolume pagination test is fragile. @avalluri showed there that it fails when the number of volumes is different. It probably also fails when csi-sanity isn't the only user of the cluster and other volumes are getting created or deleted concurrently.

I propose to disable the test in addition to fixing the volume leak. If someone has a good idea for improving the test, then they can do that later.

msau42 · 2019-10-11T01:05:03Z

Yes, @davidz627 opened up #223 outlining various problems with the ListVolumes tests. I am ok with disabling the test because the issue in #223 I think is serious enough.

msau42 · 2019-10-11T01:05:09Z

/ok-to-test

pohly

@avalluri please disable "pagination should detect volumes added between pages and accept tokens when the last volume from a page is deleted" by replacing It with XIt, with a comment that links to #223 and intel/pmem-csi#424 (comment).

pohly · 2019-10-11T07:31:48Z

mock/service/controller.go

@@ -73,7 +73,7 @@ func (s *service) CreateVolume(
 		case *csi.VolumeContentSource_Volume:
 			vid := req.GetVolumeContentSource().GetVolume().GetVolumeId()
 			// Check if the source volume exists.
-			if volID, _ := s.findVolNoLock("id", vid); volID > 0 {
+			if volID, _ := s.findVolNoLock("id", vid); volID >= 0 {


This is an unrelated change. Can you move it to a separate PR?

@avalluri please disable "pagination should detect volumes added between pages and accept tokens when the last volume from a page is deleted" by replacing It with XIt, with a comment that links to #223 and intel/pmem-csi#424 (comment).

Done.

This is an unrelated change. Can you move it to a separate PR?

Done: #227

As discussed here: kubernetes-csi#226 (review) This change fixes volume leakage in ListVolume pagination testcase and disable this case till we improve the test.

pohly · 2019-10-11T14:17:48Z

/lgtm

pohly · 2019-10-14T08:30:41Z

/approve

k8s-ci-robot · 2019-10-14T08:30:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avalluri, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest

227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 4133d1d Merge pull request kubernetes-csi#226 from msau42/cloudbuild 8d519d2 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest 6e04a03 Merge pull request kubernetes-csi#224 from msau42/cloudbuild 26fdfff Update cloudbuild image 6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae99 Update k8s image repo url 77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b Fix dep version mismatch 8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94d Update go version to 1.20 to match k/k v1.27 e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a512 test: fix golint error 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 227577e

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2019

k8s-ci-robot requested review from msau42 and saad-ali October 10, 2019 09:29

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2019

pohly requested changes Oct 11, 2019

View reviewed changes

pohly mentioned this pull request Oct 11, 2019

Leftover volume "new-addition" after "go test" intel/pmem-csi#428

Closed

sanity: fix and disable ListVolumes pagination testcase

46ef6af

As discussed here: kubernetes-csi#226 (review) This change fixes volume leakage in ListVolume pagination testcase and disable this case till we improve the test.

avalluri force-pushed the fix-listvolumes branch from 5d4a5d6 to 46ef6af Compare October 11, 2019 13:13

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019

avalluri changed the title ~~sanity: fix volume leakage~~ sanity: Disable ListVolumes pagination test Oct 11, 2019

k8s-ci-robot assigned pohly Oct 11, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019

avalluri mentioned this pull request Oct 14, 2019

Fix mock driver #227

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019

k8s-ci-robot merged commit 4e55894 into kubernetes-csi:master Oct 14, 2019

pohly mentioned this pull request Dec 9, 2019

Sanity: "pagination should detect volumes added between pages" removes volumes it didn't create & other issues #223

Open

alakae mentioned this pull request Apr 15, 2020

Update Spec to 1.1 and Implement Resize cloudscale-ch/csi-cloudscale#15

Merged

stmcginnis pushed a commit to stmcginnis/csi-test that referenced this pull request Oct 9, 2024

Merge pull request kubernetes-csi#226 from msau42/cloudbuild

4133d1d

Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sanity: Disable ListVolumes pagination test #226

sanity: Disable ListVolumes pagination test #226

avalluri commented Oct 10, 2019 •

edited

Loading

k8s-ci-robot commented Oct 10, 2019

pohly commented Oct 10, 2019

msau42 commented Oct 11, 2019

msau42 commented Oct 11, 2019

pohly left a comment

pohly Oct 11, 2019

avalluri Oct 11, 2019

avalluri Oct 11, 2019

pohly commented Oct 11, 2019

pohly commented Oct 14, 2019

k8s-ci-robot commented Oct 14, 2019

sanity: Disable ListVolumes pagination test #226

sanity: Disable ListVolumes pagination test #226

Conversation

avalluri commented Oct 10, 2019 • edited Loading

k8s-ci-robot commented Oct 10, 2019

pohly commented Oct 10, 2019

msau42 commented Oct 11, 2019

msau42 commented Oct 11, 2019

pohly left a comment

Choose a reason for hiding this comment

pohly Oct 11, 2019

Choose a reason for hiding this comment

avalluri Oct 11, 2019

Choose a reason for hiding this comment

avalluri Oct 11, 2019

Choose a reason for hiding this comment

pohly commented Oct 11, 2019

pohly commented Oct 14, 2019

k8s-ci-robot commented Oct 14, 2019

avalluri commented Oct 10, 2019 •

edited

Loading